Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18.0 mig base tier validation #964

Conversation

valentinagiuliani-rapsodoo

No description provided.

LoisRForgeFlow and others added 30 commits October 29, 2024 20:16
* able to restart validation
* sudo() not needed anymore
and reject can be hidden according to this computed field.
… and who asks for reviews in new fields 'done_by' and 'requested_by'.
fixup and extend tests

[ADD] systray icon for pending reviews

[FIX] Remove python safe_eval

[ADD] base_tier_validation_formula and migration scripts

[ADD] widget domain and python expression to define reviewer in tier definition

[ADD] auto updating of systray icon counter

[ADD] validation date field

[ADD] review widget dropdown menu
…reviews' name and state correctly translated.
* using similar approach to activities has already benn addressed.
* add a new point explaining review tooltip improvement possibilities.
Currently translated at 100.0% (59 of 59 strings)

Translation: server-ux-12.0/server-ux-12.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation/zh_CN/
mymage and others added 24 commits October 30, 2024 12:32
Currently translated at 100.0% (125 of 125 strings)

Translation: server-ux-17.0/server-ux-17.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/
- when option approve_sequence_bypass is enable and comments option with
sequence, the user add a comment and all level approbation add this
comment.
This code add comment only for appropriate tier validation.
[BOT] post-merge updates
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-17.0/server-ux-17.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/
Currently translated at 100.0% (141 of 141 strings)

Translation: server-ux-17.0/server-ux-17.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/
Silence the warning: Two fields (model_name, model_id) of tier.validation.exception() have the same label: Model. [Modules: base_tier_validation and base_tier_validation]
[BOT] post-merge updates
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-17.0/server-ux-17.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/
[BOT] post-merge updates
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-17.0/server-ux-17.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/
Currently translated at 100.0% (143 of 143 strings)

Translation: server-ux-17.0/server-ux-17.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/
Previous implementation was losing fields in some cases; new one
properly merges dicts/tuples.

This fixes odd "Missing field string information" errors in
form-embedded lists.

This cset also removes an obsolete `base_model_name` context key no
longer used in Odoo 16.

This cset adds a `test_get_view` test which checks for that
`need_validation` field; it was failing with the previous impl.

Fixes OCA#825.

[BOT] post-merge updates
Computed fields bypass `write`, so we need to override `_write` for that case.
Also, the current value before the update needs to be fetched from the database
because the new value is already set in the cache.

[BOT] post-merge updates
I just realized that a new author was added to the module during an
improvement that merged the functionality of base_tier_validation_waiting.
This was overlook during my review and not explicitly accepted. There
have been many contributors adding new functionalities and this one
was not specially big to be included as author.

[BOT] post-merge updates
[ADD][base_tier_validation] Adding test requirements

[ADD][base_tier_validation] Adding test requirements

[ADD][base_tier_validation] Adding test requirements

[FIX][base_tier_validation] Fix on tests

[FIX][base_tier_validation] Adding group on rule
@@ -95,9 +96,12 @@ def _compute_state(self):
rec.state = "draft"

def action_confirm(self):
if self.need_validation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I am mistaken this is just sidestepping this module's verification functionality

@kevinkhao
Copy link
Contributor

kevinkhao commented Nov 1, 2024

I have made another PR here #966 with split commits for pre-commit/automated fixes and different modifications. It also seems this one is missing a few commits (from 17.0?)

@valentinagiuliani-rapsodoo
Copy link
Author

close for another PR #966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.